update except usings #354
update except usings #354
Conversation
WalkthroughThis update focuses on enhancing and refining the Changes
Sequence DiagramssequenceDiagram
participant User
participant NatashaSlimMethodBuilder
participant AssemblyCSharpBuilder
participant NatashaUsingCache
User->>NatashaSlimMethodBuilder: Call WithSmartBuilder()
NatashaSlimMethodBuilder->>AssemblyCSharpBuilder: Configure builder
User->>NatashaSlimMethodBuilder: Call WithoutUsings()
NatashaSlimMethodBuilder->>AssemblyCSharpBuilder: AppendExceptUsings()
User->>AssemblyCSharpBuilder: Add script with UsingLoadBehavior
AssemblyCSharpBuilder->>AssemblyCSharpBuilder: Check ExceptUsings
AssemblyCSharpBuilder->>NatashaUsingCache: Update cache logic
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@coderabbitai review |
Actions performedReview triggered.
|
|
未检测到合适的 ISSUE 推荐给您。感谢您的反馈！
|
UT Test - Ubuntu1 tests 1 ✅ 0s ⏱️ Results for commit 9c465d9. |
UT Test - Windows1 tests 1 ✅ 0s ⏱️ Results for commit 9c465d9. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- src/Natasha.CSharp/Extension/Natasha.CSharp.Extension.MethodCreator/NatashaSlimMethodBuilder.cs (4 hunks)
- src/Natasha.CSharp/Extension/Natasha.CSharp.Extension.MethodCreator/StringExtension.cs (1 hunks)
- src/Natasha.CSharp/Natasha.CSharp.Compiler/CompileUnit/AssemblyCSharpBuilder.Syntax.cs (1 hunks)
- src/Natasha.CSharp/Natasha.CSharp.Compiler/CompileUnit/AssemblyCSharpBuilder.Usings.cs (1 hunks)
- src/Natasha.CSharp/Natasha.CSharp.Compiler/Component/Cache/NatashaUsingCache.cs (2 hunks)
- src/Natasha.CSharp/Natasha.CSharp.Compiler/Extension/NatashaStringExtension.cs (1 hunks)
Additional comments not posted (15)
src/Natasha.CSharp/Natasha.CSharp.Compiler/CompileUnit/AssemblyCSharpBuilder.Usings.cs (1)
17-24: LGTM!The method
AppendExceptUsingscorrectly adds the providedusingsto theExceptUsingsset ifusingsis not null and not empty.src/Natasha.CSharp/Extension/Natasha.CSharp.Extension.MethodCreator/StringExtension.cs (2)
30-35: LGTM!The method
WithSmartMethodBuildercorrectly creates aNatashaSlimMethodBuilderinstance and configures it withWithSmartBuilder.
37-43: LGTM!The method
WithoutUsingscorrectly creates aNatashaSlimMethodBuilderinstance, configures it withWithSmartBuilder, and then callsWithoutUsingswith the providedusings.src/Natasha.CSharp/Natasha.CSharp.Compiler/Extension/NatashaStringExtension.cs (1)
48-49: LGTM!The method
WithAllUsingCodecorrectly usesWithExceptUsingfromNatashaLoadContext.DefaultContext.UsingRecorderto exclude specified usings.src/Natasha.CSharp/Extension/Natasha.CSharp.Extension.MethodCreator/NatashaSlimMethodBuilder.cs (7)
10-10: LGTM!The private field
_exceptUsingsis correctly declared as a nullableHashSet<string>.
11-11: LGTM!The private field
_privateObjectsis correctly declared as a nullableobject[].
22-23: LGTM!The method
WithPrivateAccesscorrectly uses_privateObjectsinstead ofPrivateObjects.
43-48: LGTM!The method
WithSmartBuildercorrectly configures the builder withUseRandomLoadContextandUseSmartMode.
55-59: LGTM!The method
WithoutUsingscorrectly callsAppendExceptUsingson the builder with the providedusings.
Line range hint
93-97:
LGTM!The method
WithMetadatacorrectly uses_privateObjectsinstead ofPrivateObjects.
109-112: LGTM!The method
ToDelegatecorrectly uses_privateObjectsfor private access handling.src/Natasha.CSharp/Natasha.CSharp.Compiler/Component/Cache/NatashaUsingCache.cs (2)
Line range hint
202-216:
LGTM! Verify correctness ofWithExceptUsing(HashSet<string> exceptUsings).The method implementation looks correct. Ensure that it works as expected in various scenarios.
216-218: LGTM! Verify performance ofWithExceptUsing(IEnumerable<string> exceptUsings).The method implementation looks correct. Ensure that the conversion to
HashSet<string>does not introduce performance issues.src/Natasha.CSharp/Natasha.CSharp.Compiler/CompileUnit/AssemblyCSharpBuilder.Syntax.cs (2)
223-303: LGTM! Verify correctness ofAdd(string script, UsingLoadBehavior usingLoadBehavior, Encoding? encoding = null, string filePath = "").The method implementation looks correct. Ensure that it handles all
UsingLoadBehaviorcases as expected.
310-379: LGTM! Verify correctness ofAdd(CompilationUnitSyntax root, UsingLoadBehavior usingLoadBehavior, Encoding? encoding = null, string filePath = "").The method implementation looks correct. Ensure that it handles all
UsingLoadBehaviorcases as expected.
| /// </summary> | ||
| public sealed partial class AssemblyCSharpBuilder | ||
| { | ||
| public readonly HashSet<string> ExceptUsings = []; |
There was a problem hiding this comment.
Fix the initialization syntax for ExceptUsings.
The initialization syntax for an empty HashSet<string> is incorrect. It should be initialized using new HashSet<string>().
- public readonly HashSet<string> ExceptUsings = [];
+ public readonly HashSet<string> ExceptUsings = new HashSet<string>();Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| public readonly HashSet<string> ExceptUsings = []; | |
| public readonly HashSet<string> ExceptUsings = new HashSet<string>(); |
Summary by CodeRabbit
New Features
WithSmartBuilderandWithoutUsingsmethods for enhanced method configuration.WithSmartMethodBuilderandWithoutUsingsmethods to streamline method builder creation.Improvements
usingdirectives with the newAppendExceptUsingsmethod.Refactor
Bug Fixes
WithExceptUsingto ensure proper usage exclusion in caches.